-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hw: Add optional hardwired cluster alias region #52
Conversation
07db011
to
e63c654
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise looks good to me :)
Should I add a test to verify the functionality? This would require enabling the alias in the default cluster configuration, as the CI can currently test only one configuration. Otherwise we can extend the CI to test multiple configurations, which I think will be required in the long term, but we should discuss implementation details.
edab995
to
75ff47c
Compare
To keep track of the status, only Banshee tests are failing as this architectural feature is yet to be modeled in Banshee. |
As requested, this should be made configurable instead. Will look into that next. |
After clarifying this, it shouldn't be necessary anymore. |
75ff47c
to
30ac4d6
Compare
* docs: Update docker information * docs: Update README to use image uploaded to ghcr.io * ci: Update CI to use image uploaded in ghcr.io
18ec5af
to
d3b90f5
Compare
@fischeti could you also double-check this PR? Then we can merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This adds an optional hardwired alias region to the
snitch_cluster
in addition to the pseudostaticcluster_base_addr_i
. This is useful in multi-cluster systems (e.g. Occamy) to enable static linking and optimization of TCDM contents.Along the way, I removed some unconnected address inputs from
snitch_cluster_peripheral
.For Occamy, I recommend enabling the prefix and mapping it to
0x1800_0000
.