Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hw: Add optional hardwired cluster alias region #52

Merged
merged 7 commits into from
Feb 15, 2024
Merged

Conversation

paulsc96
Copy link
Collaborator

@paulsc96 paulsc96 commented Sep 28, 2023

This adds an optional hardwired alias region to the snitch_cluster in addition to the pseudostatic cluster_base_addr_i. This is useful in multi-cluster systems (e.g. Occamy) to enable static linking and optimization of TCDM contents.

Along the way, I removed some unconnected address inputs from snitch_cluster_peripheral.

For Occamy, I recommend enabling the prefix and mapping it to 0x1800_0000.

@paulsc96 paulsc96 changed the title hw: Add optional cluster alias region hw: Add optional hardwired cluster alias region Sep 28, 2023
@paulsc96 paulsc96 force-pushed the paulsc/tcdm-alias branch 4 times, most recently from 07db011 to e63c654 Compare September 28, 2023 21:25
@paulsc96 paulsc96 marked this pull request as ready for review September 28, 2023 21:36
Copy link
Collaborator

@colluca colluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good to me :)

Should I add a test to verify the functionality? This would require enabling the alias in the default cluster configuration, as the CI can currently test only one configuration. Otherwise we can extend the CI to test multiple configurations, which I think will be required in the long term, but we should discuss implementation details.

hw/snitch_cluster/src/snitch_cluster.sv Outdated Show resolved Hide resolved
@colluca
Copy link
Collaborator

colluca commented Sep 29, 2023

To keep track of the status, only Banshee tests are failing as this architectural feature is yet to be modeled in Banshee.

@paulsc96
Copy link
Collaborator Author

paulsc96 commented Oct 4, 2023

As requested, this should be made configurable instead. Will look into that next.

@colluca
Copy link
Collaborator

colluca commented Oct 12, 2023

As requested, this should be made configurable instead. Will look into that next.

After clarifying this, it shouldn't be necessary anymore.

@paulsc96 paulsc96 marked this pull request as draft November 23, 2023 13:52
JosseVanDelm pushed a commit to JosseVanDelm/snitch_cluster that referenced this pull request Dec 11, 2023
* docs: Update docker information

* docs: Update README to use image uploaded to ghcr.io

* ci: Update CI to use image uploaded in ghcr.io
@paulsc96 paulsc96 marked this pull request as ready for review February 14, 2024 19:17
@colluca
Copy link
Collaborator

colluca commented Feb 14, 2024

@fischeti could you also double-check this PR? Then we can merge it.

Copy link
Contributor

@fischeti fischeti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@colluca colluca merged commit b15db73 into main Feb 15, 2024
27 checks passed
@colluca colluca deleted the paulsc/tcdm-alias branch February 15, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants